changes & fixed issues causing game crashes

+ flying speed increased from 15 to 20
+ NolanBehavior_Update hooked
+ fullbright, player speed and fly moved to nolan's update hook
+ added NolanBehaviour parameter to Misc::FullBright function
- fly function removed from misc namespace (this function will be re-added in the near future after further improvements and testing.)

user/features/menu.cpp

@@ -318,7 +318,7 @@ void DrawMiscTab() {
 	*/
 
 	ImGui::Checkbox("Fly", &settings::fly);
-	ImGui::SliderFloat("Speed: ", &settings::fly_speed, 5.f, 15.f);
+	ImGui::SliderFloat("Speed: ", &settings::fly_speed, 5.f, 20.f);
 
 	/*
 	if (ImGui::Button("Make random noise")) {

user/features/misc/misc.cpp

@@ -138,54 +138,6 @@ void Misc::InstantWin()
 	}
 }
 
-// This function has not been tested
-// This function has not been tested
-// This function has not been tested
-void Misc::Fly(float speed) {
-	auto localPlayer = Player::GetLocalPlayer();
-
-	if (localPlayer == nullptr) return;
-
-	auto nb = Player::GetNolan();
-
-	app::Transform* _transform = Unity::Transform::Get(localPlayer);
-
-	if (_transform) {
-		app::Vector3 pos = Unity::Transform::Position(_transform);
-
-		if (GetAsyncKeyState('W') & 0x8000) {
-			pos = pos + (app::Transform_get_forward(_transform, nullptr) * speed * Time_DeltaTime());
-		}
-		if (GetAsyncKeyState('S') & 0x8000) {
-			pos = pos - (app::Transform_get_forward(_transform, nullptr) * speed * Time_DeltaTime());
-		}
-		if (GetAsyncKeyState('D') & 0x8000) {
-			pos = pos + (app::Transform_get_right(_transform, nullptr) * speed * Time_DeltaTime());
-		}
-		if (GetAsyncKeyState('A') & 0x8000) {
-			pos = pos - (app::Transform_get_right(_transform, nullptr) * speed * Time_DeltaTime());
-		}
-		if (GetAsyncKeyState(VK_SPACE) & 0x8000) {
-			pos = pos + (app::Transform_get_up(_transform, nullptr) * speed * Time_DeltaTime());
-		}
-		if (GetAsyncKeyState(VK_LCONTROL) & 0x8000) {
-			pos = pos - (app::Transform_get_up(_transform, nullptr) * speed * Time_DeltaTime());
-		}
-
-		auto component = Unity::GameObject::GetComponentByName(localPlayer, "UltimateCharacterLocomotion");
-
-		if (component) {
-			app::UltimateCharacterLocomotion* locomotion = reinterpret_cast<app::UltimateCharacterLocomotion*>(component);
-
-			if (locomotion) {
-				if (app::UltimateCharacterLocomotion_SetPosition_1 == nullptr) return;
-
-				app::UltimateCharacterLocomotion_SetPosition_1(locomotion, pos, false, nullptr);
-			}
-		}
-	}
-}
-
 void Misc::CustomizedLobby()
 {
 
@@ -254,16 +206,8 @@ void Misc::RankSpoofer(int value) {
 	}
 }
 
-void Misc::FullBright()
+void Misc::FullBright(app::NolanBehaviour* nb)
 {
-	std::string _scene = SceneName();
-
-	if (_scene == std::string("Menu")) {
-		return;
-	}
-
-	app::NolanBehaviour* nb = Player::GetNolan();
-
 	if (nb != nullptr) {
 		app::Light* _flashlight = nb->fields.flashlightSpot;
 

user/features/misc/misc.h

@@ -9,10 +9,9 @@ namespace Misc {
     void CarryItem(const char* itemName);
     void CarryAnimal(const char* animalName);
     void InstantWin();
-    void Fly(float speed);
     void CustomizedLobby();
     void SpawnPrefab(const char* prefabName);
-    void FullBright();
+    void FullBright(app::NolanBehaviour* nb);
     void Revive(bool self);
     void GetKeys();
     void Jumpscare();

user/hooks/hooks.cpp

@@ -60,6 +60,72 @@ void __stdcall hNolanBehaviour_OnAttributeUpdateValue(app::NolanBehaviour* __thi
 	oNolanBehaviour_OnAttributeUpdateValue(__this, attribute, method);
 }
 
+// DO_APP_FUNC(0x004AABA0, void, NolanBehaviour_Update, (NolanBehaviour * __this, MethodInfo * method));
+typedef void(__stdcall* TNolanBehaviour_Update)(app::NolanBehaviour*, MethodInfo*);
+TNolanBehaviour_Update oNolanBehaviour_Update = NULL;
+void __stdcall hNolanBehaviour_Update(app::NolanBehaviour* __this, MethodInfo* method) {
+
+	if (settings::fly && IsLocalPlayer(__this)) {
+
+		float speed = settings::fly_speed;
+
+		app::Transform* transform = app::Component_get_transform((app::Component*)__this, nullptr);
+
+		if (transform) {
+
+			app::Vector3 pos = Unity::Transform::Position(transform);
+
+			if (GetAsyncKeyState('W') & 0x8000) {
+				pos = pos + (app::Transform_get_forward(transform, nullptr) * speed * Time_DeltaTime());
+			}
+			if (GetAsyncKeyState('S') & 0x8000) {
+				pos = pos - (app::Transform_get_forward(transform, nullptr) * speed * Time_DeltaTime());
+			}
+			if (GetAsyncKeyState('D') & 0x8000) {
+				pos = pos + (app::Transform_get_right(transform, nullptr) * speed * Time_DeltaTime());
+			}
+			if (GetAsyncKeyState('A') & 0x8000) {
+				pos = pos - (app::Transform_get_right(transform, nullptr) * speed * Time_DeltaTime());
+			}
+			if (GetAsyncKeyState(VK_SPACE) & 0x8000) {
+				pos = pos + (app::Transform_get_up(transform, nullptr) * speed * Time_DeltaTime());
+			}
+			if (GetAsyncKeyState(VK_LCONTROL) & 0x8000) {
+				pos = pos - (app::Transform_get_up(transform, nullptr) * speed * Time_DeltaTime());
+			}
+
+
+			app::GameObject* thisGameObject = app::Component_get_gameObject((app::Component*)__this, nullptr);
+
+			if (thisGameObject != nullptr || !IsNull((app::Object_1*)thisGameObject)) {
+				app::Component* _UltimateCharacterLocomotion = Unity::GameObject::GetComponentByName(thisGameObject, "UltimateCharacterLocomotion");
+
+				if (_UltimateCharacterLocomotion != nullptr && !IsNull((app::Object_1*)_UltimateCharacterLocomotion)) {
+					if (app::UltimateCharacterLocomotion_SetPosition_1) {
+						app::UltimateCharacterLocomotion_SetPosition_1((app::UltimateCharacterLocomotion*)_UltimateCharacterLocomotion, pos, false, nullptr);
+					}
+				}
+			}
+		}
+	}
+
+	if (settings::change_player_speed && IsLocalPlayer(__this)) {
+		// Apply Sprint Speed
+		if (__this->fields.speedChangeAbility)
+		{
+			__this->fields.speedChangeAbility->fields.m_SpeedChangeMultiplier = (float)settings::new_speed;
+			__this->fields.speedChangeAbility->fields.m_MaxSpeedChangeValue = (float)settings::new_speed;
+		}
+	}
+
+	if (settings::fullBright && IsLocalPlayer(__this)) {
+		Misc::FullBright(__this);
+	}
+
+	oNolanBehaviour_Update(__this, method);
+}
+
+
 // DO_APP_FUNC(0x004A7D70, void, NolanBehaviour_FixedUpdate, (NolanBehaviour* __this, MethodInfo* method));
 typedef void(__stdcall* TNolanBehaviour_FixedUpdate)(app::NolanBehaviour*, MethodInfo*);
 TNolanBehaviour_FixedUpdate oNolanBehaviour_FixedUpdate = NULL;
@@ -83,16 +149,6 @@ void __stdcall hNolanBehaviour_FixedUpdate(app::NolanBehaviour* __this, MethodIn
 		}
 	}
 
-
-	if (settings::change_player_speed && IsLocalPlayer(__this)) {
-		// Apply Sprint Speed
-		if (__this->fields.speedChangeAbility)
-		{
-			__this->fields.speedChangeAbility->fields.m_SpeedChangeMultiplier = (float)settings::new_speed;
-			__this->fields.speedChangeAbility->fields.m_MaxSpeedChangeValue = (float)settings::new_speed;
-		}
-	}
-
 	oNolanBehaviour_FixedUpdate(__this, method);
 }
 
@@ -377,7 +433,14 @@ void CreateHooks() {
 		return;
 	}
 
-	// NOLAN HOOK
+	// NOLAN UPDATE HOOK
+	MH_STATUS status_nolanUpdate = MH_CreateHook((LPVOID*)app::NolanBehaviour_Update, &hNolanBehaviour_Update, reinterpret_cast<LPVOID*>(&oNolanBehaviour_Update));
+	if (status_nolanUpdate != MH_OK) {
+		std::cout << "Failed to create nolan update hook: " << MH_StatusToString(status_nolanUpdate) << std::endl;
+		return;
+	}
+
+	// NOLAN FIXED HOOK
 	MH_STATUS status_nolan = MH_CreateHook((LPVOID*)app::NolanBehaviour_FixedUpdate, &hNolanBehaviour_FixedUpdate, reinterpret_cast<LPVOID*>(&oNolanBehaviour_FixedUpdate));
 	if (status_nolan != MH_OK) {
 		std::cout << "Failed to create nolan hook: " << MH_StatusToString(status_nolan) << std::endl;
@@ -632,14 +695,10 @@ HRESULT __stdcall hookD3D11Present(IDXGISwapChain* pSwapChain, UINT SyncInterval
 		DrawMenu(open_menu);
 	}
 
+	// to-do: move it to "fixed update" hook
 	if (settings::player_esp)
 		ESP::RunPlayersESP();
 
-	if (settings::fly)
-		Misc::Fly(settings::fly_speed);
-		
-	if (settings::fullBright)
-		Misc::FullBright();
 
 	ImGui::GetIO().MouseDrawCursor = open_menu;