e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
54 lines
1.1 KiB
Nix
54 lines
1.1 KiB
Nix
{
|
|
stdenv,
|
|
lib,
|
|
buildPythonPackage,
|
|
fetchFromGitHub,
|
|
pytestCheckHook,
|
|
chardet,
|
|
cssselect,
|
|
lxml,
|
|
lxml-html-clean,
|
|
timeout-decorator,
|
|
}:
|
|
|
|
buildPythonPackage rec {
|
|
pname = "readability-lxml";
|
|
version = "0.8.1";
|
|
format = "setuptools";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "buriy";
|
|
repo = "python-readability";
|
|
rev = "v${version}";
|
|
hash = "sha256-MKdQRety24qOG9xgIdaCJ72XEImP42SlMG6tC7bwzo4=";
|
|
};
|
|
|
|
propagatedBuildInputs = [
|
|
chardet
|
|
cssselect
|
|
lxml
|
|
lxml-html-clean
|
|
];
|
|
|
|
postPatch = ''
|
|
substituteInPlace setup.py --replace 'sys.platform == "darwin"' "False"
|
|
'';
|
|
|
|
nativeCheckInputs = [
|
|
pytestCheckHook
|
|
timeout-decorator
|
|
];
|
|
|
|
disabledTests = lib.optionals stdenv.hostPlatform.isDarwin [
|
|
# Test is broken on darwin. Fix in master from https://github.com/buriy/python-readability/pull/178
|
|
"test_many_repeated_spaces"
|
|
];
|
|
|
|
meta = with lib; {
|
|
description = "Fast python port of arc90's readability tool";
|
|
homepage = "https://github.com/buriy/python-readability";
|
|
license = licenses.asl20;
|
|
maintainers = with maintainers; [ siraben ];
|
|
};
|
|
}
|