From 35789184457accfa04fac029424e4fb14bfc8d48 Mon Sep 17 00:00:00 2001 From: Martin Weinelt Date: Fri, 2 Aug 2024 23:20:17 +0200 Subject: [PATCH 1/2] python312Packages.botorch: disable stuck tests on x86_64-linux and log individual tests, so it becomes easier to find out which tests get stuck. --- .../development/python-modules/botorch/default.nix | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/pkgs/development/python-modules/botorch/default.nix b/pkgs/development/python-modules/botorch/default.nix index da41939cde90..5a26f8f18151 100644 --- a/pkgs/development/python-modules/botorch/default.nix +++ b/pkgs/development/python-modules/botorch/default.nix @@ -1,5 +1,6 @@ { lib, + stdenv, buildPythonPackage, fetchFromGitHub, gpytorch, @@ -46,7 +47,18 @@ buildPythonPackage rec { nativeCheckInputs = [ pytestCheckHook ]; - disabledTests = [ "test_all_cases_covered" ]; + pytestFlagsArray = [ + # tests tend to get stuck on busy hosts, increase verbosity to find out + # which specific tests get stuck + "-vvv" + ]; + + disabledTests = + [ "test_all_cases_covered" ] + ++ lib.optionals (stdenv.buildPlatform.system == "x86_64-linux") [ + # stuck tests on hydra + "test_moo_predictive_entropy_search" + ]; pythonImportsCheck = [ "botorch" ]; From 62a8e3308ecc8658b3876a1d11b0973133bf3286 Mon Sep 17 00:00:00 2001 From: Martin Weinelt Date: Sat, 3 Aug 2024 01:55:03 +0200 Subject: [PATCH 2/2] python312Packages.botorch: require big-parallel system feature The test phase for this package is very CPU intensive and prone to getting stuck when it has to compete for resources. --- pkgs/development/python-modules/botorch/default.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/development/python-modules/botorch/default.nix b/pkgs/development/python-modules/botorch/default.nix index 5a26f8f18151..7a860437c1b8 100644 --- a/pkgs/development/python-modules/botorch/default.nix +++ b/pkgs/development/python-modules/botorch/default.nix @@ -62,6 +62,9 @@ buildPythonPackage rec { pythonImportsCheck = [ "botorch" ]; + # needs lots of undisturbed CPU time or prone to getting stuck + requiredSystemFeatures = [ "big-parallel" ]; + meta = with lib; { changelog = "https://github.com/pytorch/botorch/blob/${src.rev}/CHANGELOG.md"; description = "Bayesian Optimization in PyTorch";